rafalp/Misago

Attachment markup updater explodes if attachment is used after quote

Open

#1961 opened on Jun 28, 2025

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (2,409 stars) (509 forks)batch import
area: backendbugcriticalhelp wanted

Description

Troublesome post on Misago forums:

https://misago-project.org/t/deactivate-sslhttps-use-extern-reverse-proxy/1216/post/5854/

Markup:

[quote="@rafalp"]
AFAIR simplest way to achieve that is to create fork of `misago-docker` that deletes `nginx-lets-encrypt` from `docker-compose.yml` file.
[/quote]

[![grafik.png](/a/thumb/W4BU4idEGEfQD4RRalMaU3LloVyLgQvtqLK27VDWtvKBPS174jzZhb9s3BZDTmer/602/?shva=1)](/a/W4BU4idEGEfQD4RRalMaU3LloVyLgQvtqLK27VDWtvKBPS174jzZhb9s3BZDTmer/602/?shva=1)

Gets mangled into:

quote="@rafalp" <attachment=grafik.png:602>](/a/W4BU4idEGEfQD4RRalMaU3LloVyLgQvtqLK27VDWtvKBPS174jzZhb9s3BZDTmer/602/?shva=1)

Contributor guide

Tech stack
pythonhtmlcssjavascript
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of PythonFamiliarity with Misago's markup system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine the attachment markup updater code in Misago, likely located in the `misago/core/markup.py` file. Focus on how it processes quote blocks and attachment references. The issue occurs when an attachment image is placed after a quote, causing incorrect concatenation. Look for the regex or string operations that handle the attachment replacement and ensure they account for preceding quote markup.