radareorg/radare2

Every call to RNum.math or .get should check be checking for errors

Open

#23,362 opened on Sep 20, 2024

View on GitHub
 (0 comments) (0 reactions) (1 assignee)C (23,826 stars) (3,229 forks)batch import
good first issue

Description

This is important to not get users confused with unexpected behaviours

for example:

Contributor guide

Tech stack
c
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C programmingError handling patternsRadare2 RNum API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue states that all calls to RNum.math or .get should check for errors, referencing PR #23361 as an example. Since the issue is assigned, new contributors should first check with the assignee. If available, study the pattern in PR #23361, then grep the codebase for RNum.math and RNum.get calls and add error checks where missing. The relevant source files are likely in libr/core or libr/anal. Focus on functions that use these RNum methods.
Every call to RNum.math or .get should check be checking for errors · radareorg/radare2#23362 | Good First Issue