radareorg/radare2

Colorize the `pf` output (especially in `r2 -nn binary` case)

Open

#16,193 opened on Mar 12, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C (23,826 stars) (3,229 forks)batch import
enhancementgood first issuehackatonpfvisual

Description

Is your feature request related to a problem? Please describe. Currently radare2 prints both pf and built-in pf output in r2 -nn mode without any colors, even if they are enabled. It would be amazing to improve the readability to colorize them according to the current color options and colorscheme.

image

Contributor guide

Tech stack
c
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with CUnderstanding of radare2's color system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests colorizing the 'pf' output in radare2, especially in 'r2 nn' mode. To implement, examine how colors are currently applied in the codebase, likely in files like libr/core/p.c or libr/core/cmd print.c. Look at the existing color configuration and how it's used for other commands. The task involves modifying the print functions to respect the current color scheme. No linked PRs or comments provide further direction.