radareorg/radare2

Add * and j in all the missing commands

Open

#13,969 opened on May 6, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C (23,826 stars) (3,229 forks)batch import
FEEDBACK WANTEDHacktoberfestIMPORTANTgood first issuejson

Description

For consistency and standarization: use the PJ api

  • aoq + ao*
  • b* bj
  • y* yj
  • cj c*
  • rj r*
  • P*
  • pj p* - what do here
  • a* aj - whta info to show?
  • uj u*
  • wj w* - does it make sense?
  • lj l* - json version of ls
  • #!j #!*
  • Lj Llj, ....
  • kj have some newlines https://github.com/radareorg/radare2/pull/17258
  • k* is not working

Missing helps

  • v?

Contributor guide

Tech stack
c
Domain
clitooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of radare2 command systemfamiliarity with PJ APIC programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
First, examine the existing implementations of commands that are already completed (e.g., b*, bj, y*, yj) in the radare2 codebase, likely in libr/core/cmd*.c or similar. Look at the PJ API usage in those to understand the pattern. Also review the linked pull request #17258 for kj to see how newlines were handled. For ambiguous items like pj/p* and a*/aj, check recent comments or maintainer responses for clarification. Focus on one subtask at a time, starting with those marked with questions.