radareorg/radare2

pf output is confusing

Open

#12,726 opened on Jan 10, 2019

View on GitHub
 (8 comments) (1 reaction) (2 assignees)C (3,229 forks)batch import
FEEDBACK WANTEDgood first issuepf

Repository metrics

Stars
 (23,826 stars)
PR merge metrics
 (Avg merge 16h 24m) (99 merged PRs in 30d)

Description

i think offset should go first, like it does in px or pd

[0x00000000]> pf xxd foo bar cow
 foo : 0x00000000 = 0xfeedfacf
 bar : 0x00000004 = 0x01000007
 cow : 0x00000008 = 2147483651

should be

[0x00000000]> pf xxd foo bar cow
0x00000000  foo 0xfeedfacf
0x00000004  bar 0x01000007
0x00000008  cow 2147483651

Contributor guide

Research direction
Find the pf command implementation in the radare2 codebase. The output format is defined somewhere in the print formatting functions. Change the order of printing to show offset first, then name, then value.
Tech stack
c
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75