router uplink dynamic VLAN segment leaked on interface removal
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- python
- Domain
- networking
Research direction
Start in neutron_understack/routers.py at _do_uplink_cleanup, then read neutron_understack/tests/scenarios/test_router_uplink.py and scenario OVN-ROUTER-DETACH-01. Run that scenario to confirm the strict xfail currently fails; done means the allocated VLAN segment is absent after remove_router_interface and the strict xfail can be removed.
Written by the indexing model from the issue text.
Description
Summary
The router uplink teardown leaks the dynamically allocated VLAN segment.
When a router interface is removed (or the router is deleted),
neutron_understack.routers._do_uplink_cleanup deletes the network-node
trunk subport, the OVN localnet + shared-port LSPs, and the shared neutron
port — but it never releases the dynamic VLAN segment that
fetch_or_create_router_segment allocated on the network-node physnet. The
segment (and its VLAN id) leaks on every router-interface removal / router
delete.
Component: python/neutron-understack — neutron_understack.routers
Severity: Medium — VLAN id exhaustion on the network-node physnet over time.
Reproduction
Scenario OVN-ROUTER-DETACH-01
(neutron_understack/tests/scenarios/test_router_uplink.py) asserts the
segment is released after remove_router_interface, marked
xfail(strict=True). It fails without the fix: the segment
(network_type=vlan, the network-node physnet) is still present after
teardown.
Fix direction
In _do_uplink_cleanup, after deleting the shared port, release the segment
if unused (mirroring the baremetal delete path):
release_segment_if_unused(network_segment_by_id(segment_id)). A fix branch
implementing this exists; merging it flips the strict xfail to a pass,
prompting removal of the marker.
- Dominant language
- Python
- Stars
- 13
- Forks
- 12
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 73
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rackerlabs/understack
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
rackerlabs/understack#2193 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
rackerlabs/understack#2346 ·
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
rackerlabs/understack#2343 ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 68/100
rackerlabs/understack#2342 ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 72/100
rackerlabs/understack#2335 ·
All issues in rackerlabs/understack
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100