checking for named_arg

Open
#435 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp, r
Domain
tooling

Research direction

Start at inst/include/cpp11/r_vector.hpp around line 879 and compare the initializer_list<r_string> specialization with the named_arg constructor. Check how named_arg currently handles checking and UTF-8 translation; done means the intended behavior is decided and implemented consistently.

Written by the indexing model from the issue text.

Description

TODO: The equivalent ctor from initializer_list<r_string> has a specialization for <r_string> to translate elt to UTF-8 before assigning. Should we have that here (https://github.com/r-lib/cpp11/blob/main/inst/include/cpp11/r_vector.hpp#L879) too? named_arg doesn't do any checking here.

Dominant language
C++
Stars
224
Forks
52
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from r-lib/cpp11

All issues in r-lib/cpp11

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.