`BEGIN_CPP11 + END_CPP11` -> using `Rf_errorcall(call, ...)`

Open
#354 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp, r
Domain
tooling

Research direction

Start with inst/include/cpp11/declarations.hpp around END_CPP11 and R/register.R around generate_cpp_functions(). Trace how package and funs$name are available to generated functions, then determine the intended macro or sibling interface. Done means the generated code can construct a call for Rf_errorcall() instead of passing R_NilValue, with coverage for the resulting behavior.

Written by the indexing model from the issue text.

Description

I believe we could expand on END_CPP11 (or add a sibling).

https://github.com/r-lib/cpp11/blob/51f4cd5ad9425a491dedf951a3679346d416e51c/inst/include/cpp11/declarations.hpp#L47-L63

so that it would take parameters, easily generated in generate_cpp_functions(), i.e. package and funs$name

https://github.com/r-lib/cpp11/blob/51f4cd5ad9425a491dedf951a3679346d416e51c/R/register.R#L165-L185

so that we could construct a call to use in Rf_errorcall() instead of using R_NilValue.

Dominant language
C++
Stars
224
Forks
52
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from r-lib/cpp11

All issues in r-lib/cpp11

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.