`as_integers` and `as_doubles` should understand logical inputs

Open

#297 opened on Nov 2, 2022 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 3/5
Estimated time: 1-2 days
Newbie friendliness: 45/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: cpp, r
Domain: tooling

Research direction

Start by reading the as_integers and as_doubles entry points, along with the existing as_integer conversion and the work referenced in #265. Reproduce the all-NA logical-input case described in the issue, then verify that logical inputs are handled consistently by both conversions and that the relevant tests pass.

Written by the indexing model from the issue text.

Description

Arguably logicals are also "integer like", but the main use case is the all-NA input vectors. When a user enters xyz(arg = NA) and arg is intended to be an integer the cpp level conversion with as_integers fails.

For this reason as_integers is still incomplete because we still need a custom wrapper around as_integer for logicals internally.

Would be really great if it could be done as part of #265 (cc @DavisVaughan)

Dominant language: C++
Stars: 224
Forks: 52
PR merge metrics: No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

Use 4:4:4 for multichannel AVIF and HEIF gain maps Open

Difficulty 2/5 1-3 hours Newbie friendliness 70/100

google/libultrahdr#485 · Opened Sep 24, 2026
Missing tile warnings in TileMap dock display with wrong texture filter Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

godotengine/godot#123776 · Opened Sep 23, 2026
if(cond,a,b) treats any nonzero cond as true in every bngsim backend (ExprTk interpreter, C codegen, SSA), which contradicts docs/reference/expressions.md ('true when > 0.5') and BNG's run_network. A non-boolean condition in (-inf,0) or... Open

bug

Difficulty 1/5 Under an hour Newbie friendliness 60/100

lanl/bngsim#774 · Opened Sep 23, 2026
Delete ament_export_include_directories() and ament_export_libraries() calls Open

good first issue

Difficulty 1/5 Under an hour Newbie friendliness 90/100

ros2/rosbag2#2509 · Opened Sep 23, 2026
Delete ament_export_include_directories() and ament_export_libraries() calls Open

good first issue

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

ros2/common_interfaces#344 · Opened Sep 23, 2026

More C++ issues