qutebrowser/qutebrowser

Ignore window.confirm/alert/prompt in background tabs/windows

Open

#4,106 opened on Aug 3, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Python (9,161 stars) (1,014 forks)batch import
good first issuepriority: 0 - high

Description

Other browsers do that as well, e.g. Chromium

Also see https://docs.google.com/document/d/1wtV5rmLhbf1OZkbg7crtCt6h1mMtig_ctTQt3BLLEIU/edit

Contributor guide

Tech stack
python
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python knowledgeQt WebEngine basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests that qutebrowser suppress window.confirm(), window.alert(), and window.prompt() dialogs when the tab or window is in the background. This behavior mirrors Chromium's implementation. The implementation likely involves modifying QWebEnginePage's JavaScript dialog handling, possibly in the page or tab classes. Check files such as qutebrowser/browser/webengine/webengine tab.py or similar for signal handling. Consult the Chromium documentation linked in the issue for reference. The task is to detect background state and silently accept or ignore dialogs without user interaction.