quran/quran.com-frontend

Convert Smartbanner to styled-components

Open

#1,020 opened on Aug 29, 2018

View on GitHub
 (10 comments) (0 reactions) (0 assignees)JavaScript (358 forks)batch import
good first issue

Repository metrics

Stars
 (953 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I'm submitting a ...

  • bug report
  • feature request
  • other

Current behavior: The Smartbanner component is heavily using CSS and should instead use styled-components

Expected / new behavior: Convert to styled-components please!

Contributor guide

Research direction
Review the Smartbanner component's current CSS and convert it to styled components following the project's existing patterns.
Tech stack
javascriptreactcss
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReactCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75