quran/quran.com-frontend

Convert Smartbanner to styled-components

Open

#1020 opened on Aug 29, 2018

View on GitHub
 (10 comments) (0 reactions) (0 assignees)JavaScript (953 stars) (358 forks)batch import
good first issue

Description

I'm submitting a ...

  • bug report
  • feature request
  • other

Current behavior: The Smartbanner component is heavily using CSS and should instead use styled-components

Expected / new behavior: Convert to styled-components please!

Contributor guide

Tech stack
javascriptreactcss
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React basicsstyled components knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Locate the Smartbanner component and its associated CSS files. Review the styled components documentation to understand how to convert the existing CSS into styled components. Check the issue comments for any suggested approaches or constraints. Ensure the conversion maintains the same visual appearance and functionality.