quickwit-oss/tantivy

Make the behavior of an empty query configurable in `QueryParser`

Open

#386 opened on Aug 20, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Rust (499 forks)batch import
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (8,354 stars)
PR merge metrics
 (Avg merge 12d 14h) (20 merged PRs in 30d)

Description

In some use case, most of the time, people want an empty query to match nothing, but for some analytics use case, it might make more sense for empty query to match all documents.

Add a setter ".set_empty_query_match_all(should_match_all: bool)" to the QueryParser to enforce the non default behavior. (Also add a getter .get_empty_query_match_all() to read this property).

Contributor guide

Research direction
Add a boolean field `empty query match all` to `QueryParser` with corresponding setter and getter methods. Modify the parsing logic in `QueryParser::parse query` to check this flag when the query string is empty: if true, return a match all query; if false (default), return a match none query. Ensure thread safety and update any relevant tests.
Tech stack
rust
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70