quickwit-oss/tantivy

Tantivy should work without a store/fieldnorm/position file

Open

#124 opened on Apr 24, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (8,354 stars) (499 forks)batch import
enhancementgood first issue

Description

Currently tantivy creates empty file even if the schema does not requires them (e.g. no field in the schema is stored for instance). The segment reader also needlessly opens and mmaps these files. jwolfe lost a bit of time when writing a converter from a different search index to tantivy.

Contributor guide

Tech stack
rust
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingfile I/O concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the segment reader code in Tantivy that creates and opens store, fieldnorm, and position files. The issue suggests that these files are created even when the schema doesn't require them. Start by locating where these files are initialized (likely in the segment or index writer). Then, modify the logic to conditionally create and open them based on the schema's stored fields, field norms, and positions. Also review the reader side to avoid mmap'ing unnecessary files. Check the repository's git history for any partial attempts or discussions around this issue. Update existing tests to verify the new behavior.