quickwit-oss/quickwit

Fix bad pattern used in CLI argument parsing

Open

#881 opened on Dec 10, 2021

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Rust (553 forks)github user discovery
backlogenhancementgood first issuelow-priority

Repository metrics

Stars
 (11,300 stars)
PR merge metrics
 (PR metrics pending)

Description

As suggested by @guilload

Would be better to use this pattern:

let metastore_uri = matches
    .value_of("metastore-uri")
    .map(normalize_uri)
    .expect("`metastore-uri` should be a required arg.")?;

Contributor guide

Research direction
Find the file containing CLI argument parsing and replace the current pattern with the suggested one using `map` and `expect`.
Tech stack
rust
Domain
backendcli
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75