read_por is untested and has no fixture

Open Beginner friendly
#96 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
75/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
julia
Domain
testing

Research direction

Inspect the existing format test item in test/ and the read_por and read_xport entry points, then compare the available test/types.por fixture from StatFiles. Add the .por fixture and coverage for read_por, including the unknown row-count path handled by handle_variable!. Done means the SPSS portable reader has a passing test like the other supported formats.

Written by the indexing model from the issue text.

Description

Found while auditing the stack (see #95).

read_por is exported and documented, but the test item only covers read_dta, read_sav, read_sas7bdat and read_xport. There is no types.por fixture in test/, so the SPSS portable reader has no coverage at all.

StatFiles does ship a test/types.por, which could be reused here, though it likewise has no test exercising it (queryverse/StatFiles.jl#32).

Worth doing alongside that: SPSS portable files exercise a genuinely different code path in readstat, and .por is the one format where the row count comes back unknown (-1), the same case read_xport hits and which handle_variable! has a special branch for.

🤖 Generated with Claude Code

Dominant language
Julia
Stars
79
Forks
18
Avg merge
22h 31m
Merged PRs (30d)
3

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from queryverse/ReadStat.jl

All issues in queryverse/ReadStat.jl

Similar issues

More Julia issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.