qmk/qmk_firmware

[Bug] MODS_TO_NEUTRALIZE ignored in Layer activated by Hold-Tap button

Open

#24,123 opened on Jul 15, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Describe the Bug

I have a mod-tap key in Layer 2: MT(MOD_LGUI, KC_6) Layer 2 is activated from a hold-tap button: LT(MO(2), KC_ENT)

I have neutralized GUI, but with the above conditions a hold causes GUI action to trigger. Note that if I replace the layer-activation button with a non-hold-tap one, neutralization works correctly: MO(2)

Keyboard Used

splitkb/aurora/sweep/rev1

Link to product page (if applicable)

No response

Operating System

Windows 11

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

Flags in config.h: #define QUICK_TAP_TERM 0 #define TAPPING_TERM 175 #define PERMISSIVE_HOLD #define RETRO_TAPPING #define RETRO_TAPPING_PER_KEY #define MODS_TO_NEUTRALIZE { MOD_BIT(KC_LGUI), MOD_BIT(KC_LALT) } #define DUMMY_MOD_NEUTRALIZER_KEYCODE KC_RIGHT_CTRL

Contributor guide

Research direction
Investigate the interaction between hold tap layer activation (LT) and MODS TO NEUTRALIZE. The bug suggests that when a layer is activated via a hold tap button, neutralization of modifiers (e.g., GUI) is not applied. Check the order of operations in process record() and how hold tap timers affect modifier state. Look at the implementation of mods to neutralize and dummy mod neutralizer keycode to see if they are bypassed during layer changes. Consider whether the hold tap release triggers a modifier press before neutralization can occur.
Tech stack
c
Domain
embedded iot
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CQMK firmware basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50