qmk/qmk_firmware

[Bug] Cirque will override mouse button status in relative mode even when CIRQUE_PINNACLE_TAP_ENABLE is not set.

Open

#24,088 opened on Jul 11, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Describe the Bug

I have mouse buttons under my thumb operated keys on my keyboard. Then in pointing_device_task_user mouse keys status is already changed to what Cirque is putting into it's mouse_report thus overriding my own report. Because of that I can't do click/drag because Cirque will set mouse button status to 0 thus making mouse key up event. I've pinned down the issue to this line. This only happens in relative mode.

Keyboard Used

No response

Link to product page (if applicable)

No response

Operating System

No response

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

Contributor guide

Research direction
Inspect the Cirque relative mode handler at quantom/pointing device/pointing device drivers.c line 355. Add a conditional check to only override mouse report buttons when CIRQUE PINNACLE TAP ENABLE is defined, preserving the existing button state otherwise.
Tech stack
c
Domain
None
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC programmingQMK firmware basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60