qmk/qmk_firmware

[Bug] "Swap Hands One Shot" cannot be locked like other "One Shot Keys"

Open

#22,481 opened on Nov 15, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Describe the Bug

When using the swap hands one shot key (SH_OS), it is not possible to lock the swap hands by pressing it "ONESHOT_TAP_TOGGLE" times. I would have expected that it behaves like other one shot keys for modifiers and layers, which can be locked by pressing them repeatedly.

Keyboard Used

ZSA Voyager

Link to product page (if applicable)

No response

Operating System

Linux (Ubuntu 22.04)

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

Contributor guide

Research direction
Examine the swap hands one shot implementation in quantum/process keycode/process oneshot.c and compare with other one shot keys like oneshot mod or oneshot layer. Determine why the tap toggle locking mechanism is not triggered for swap hands and implement the missing logic.
Tech stack
c
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC programmingQMK basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55