qmk/qmk_firmware

[Bug] combo_ref_from_layer doesn't respect different default layer

Open

#21,780 opened on Aug 19, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Describe the Bug

combo_ref_from_layer doesn't respect different default layer when the default layer is not layer 0.

Keyboard Used

No response

Link to product page (if applicable)

No response

Operating System

No response

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

Contributor guide

Research direction
Look at the combo ref from layer function in the QMK source code to understand how it retrieves the layer reference. Trace the calls and see why it fails when the default layer is not 0. Test with a configuration that sets a different default layer.
Tech stack
c
Domain
embedded iot
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
CEmbedded Systems
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60