qmk/qmk_firmware

[Bug] 1upkeyboards pi60 info.json has wrong information about the left shift key; a simple patch fixed it

Open

#21,065 opened on May 27, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Describe the Bug

The firmware when compiled for the 1upkeyboards pi60 doesn't register the left shift key.

The solution is to patch the line

{ "label": "LShift", "matrix": [3, 15], "w": 1.25, "x": 0, "y": 3 },

This is currently [3, 0], which doesn't match the label on the PCB itself.

Keyboard Used

1upkeyboards pi60

Link to product page (if applicable)

No response

Operating System

No response

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

Contributor guide

Research direction
Open the info.json file for the 1upkeyboards pi60 keyboard, locate the left shift key entry, and change its matrix from '[3,0]' to '[3,15]' to match the PCB label. Then compile and test the firmware.
Tech stack
c
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90