qmk/qmk_firmware

[Bug] `AUTO_SHIFT_MODIFIERS` occasionally sends single key instead of with-modifier-variant

Open

#19,671 opened on Jan 23, 2023

View on GitHub
 (9 comments) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Describe the Bug

Since I've enabled AUTO_SHIFT_MODIFIERS, I have the issue that ~5% of all uses/presses of e.g. CTRL+c (copy to clipboard) just send a c instead of CTRL+c.

I thought it might be that I unintentionally press CTRL+c for too long (longer than AUTO_SHIFT_TIMEOUT, which is 150ms in my case), and thus it sends CTRL+SHIFT+c (as expected, when you press it for too long), but this is not the case: it doesn't send CTRL+SHIFT+c, but actually only c.

Seems like a bug to me. Here is my keyboard code. Any ideas?

Keyboard Used

sculpter

Link to product page (if applicable)

No response

Operating System

Windows 10

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

Contributor guide

Research direction
Examine the AUTO SHIFT MODIFIERS implementation in QMK's process record functions, particularly how modifier keys are handled during auto shift. Look for race conditions or timing issues that could cause the modifier to be dropped.
Tech stack
c
Domain
embedded iot
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50