qmk/qmk_firmware

[Bug] info.json in subfolder not overridding info.json in top-level folder

Open

#19,256 opened on Dec 7, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Describe the Bug

If a feature is set in a top-level keyboard folder's info.json (ex. keebio/sinc/info.json), it can't be overridden by a subfolder's info.json (ex. keebio/sinc/rev2/info.json). Overridding a feature using rules.mk (ex. keebio/sinc/rev2/rules.mk) works fine.

Keyboard Used

qmk info -f json -kb keebio/sinc/rev2 -km via | head -n50

Link to product page (if applicable)

No response

Operating System

No response

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

Contributor guide

Research direction
Investigate how QMK's build system merges info.json files from keyboard top level and revision subfolders. Look for the code that handles JSON loading and merging, possibly in `lib/python/qmk/info.py` or similar. Check for any order dependent behavior or missing recursive merging logic.
Tech stack
c
Domain
None
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
CQMK firmware build system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50