qmk/qmk_firmware

[Bug] one shot modifier isn't timed out after clicking with mouse

Open

#17,045 opened on May 9, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Describe the Bug

config and keymap

  1. tap OSM(MOD_LCTRL)
  2. click link in mozilla to open link in new tab
  3. scroll wheel will change zoom level (expected to scroll page) until i consume osm by clicking a letter; it won't time out.

System Information

Keyboard:ferris sweep Revision (if applicable): Operating system:windows 10 qmk doctor output:

Ψ QMK Doctor is checking your environment.
Ψ CLI version: 1.0.0
Ψ QMK home: C:/Users/ryanh/_home/qmk_firmware
Ψ Detected Windows 10 (10.0.19044).
Ψ Git branch: master
Ψ Repo version: 0.16.9
⚠ Git has unstashed/uncommitted changes.
⚠ The official repository does not seem to be configured as git remote "upstream".
Ψ All dependencies are installed.
Ψ Found arm-none-eabi-gcc version 10.1.0
Ψ Found avr-gcc version 8.4.0
Ψ Found avrdude version 6.4
Ψ Found dfu-util version 0.11
Ψ Found dfu-programmer version 0.7.2
Ψ Submodules are up to date.
Ψ QMK is ready to go, but minor problems were found

Any keyboard related software installed?

  • AutoHotKey (Windows) not running
  • Karabiner (macOS)
  • Other:

Additional Context

Contributor guide

Research direction
Investigate the one shot modifier timeout logic in QMK firmware, focusing on the process record function and how mouse clicks are handled. Look at the OSM code and trace the timer reset conditions.
Tech stack
c
Domain
embedded iot
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
CGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50