qmk/qmk_firmware

[Bug] RGBLED_NUM needs one more than actual number of LEDs

Open

#14,483 opened on Sep 17, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Describe the Bug

The last LED in the row of addressable RGB LEDs on my keyboard fails to light up when using the standard firmware. Increasing the number of LEDs defined in config.h by one solves the problem. The value then is 5 though, while I have only 4 LEDs on the keyboard.

System Information

  • Keyboard: Keebio BDN9
    • Revision (if applicable): Rev. 1
  • Operating system: Windows 10
  • AVR GCC version: 5.4.0
  • ARM GCC version: 9.2.1 20191025
  • QMK Firmware version: 0.14.16
  • Any keyboard related software installed?
    • AutoHotKey
    • Karabiner
    • Other:

Additional Context

The LEDs use SK6812 drivers, which should be drop-in clones of the WS2812B.

Contributor guide

Research direction
Examine how RGBLED NUM is used in the QMK firmware to control LED addressing. Check the LED driver initialization code to see if there is an off by one error in the loop that sets each LED. Compare with the actual number of LEDs on the keyboard.
Tech stack
c
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50