qmk/qmk_firmware

[Bug] OSM and OSL not working on non-zero default layer

Open

#13,661 opened on Jul 23, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

I am working on a one-handed layout, on which I am trying to use OSM for a sticky shift and OSL for a symbol layer. For obvious reasons this is not the default layer. I am running into an issue where neither OSM and OSL works when the one-handed layer is set to default (via DF(7)). OSM(MOD_LSFT) still works when held, but not when tapped. Other modifiers are not working either. OSL is even weirder - the keycode I have is OSL(10), and hitting it actually causes browser to go back one page.

Contributor guide

Research direction
Investigate the handling of one shot keys (OSM/OSL) when the default layer is not layer 0. Trace the code path in process record quantum and layer state set functions to see why OSM and OSL behave incorrectly on non zero default layers.
Tech stack
c
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70