qmk/qmk_firmware

[Bug] rgblight_setrgb_slave should be rgblight_setrgb_slave_at

Open

#13,500 opened on Jul 8, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Describe the Bug

I expect to be able to set the lights on slave the same as in master. Like rgblight_sethsv_at, I expect to have rgblight_setrgb_slave_at.

Contributor guide

Research direction
Locate the function `rgblight setrgb slave` in the source code and either rename it to `rgblight setrgb slave at` or add an alias. Check for any callers that need updating.
Tech stack
c
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90