qmk/qmk_firmware

[Bug] With Autoshift Enabled, holding Enter does not send Shift+Enter

Open

#13,469 opened on Jul 6, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Describe the Bug

With Autoshift Enabled, holding Enter does not send Shift + Enter.

System Information

  • Keyboard: DZ60 ANSI
    • Revision (if applicable): v2
  • Operating system: MacOS
  • AVR GCC version: avr-gcc (Homebrew AVR GCC 8.4.0_1) 8.4.0
  • ARM GCC version: arm-none-eabi-gcc (GNU Tools for Arm Embedded Processors 8-2019-q3-update) 8.3.1 20190703 (release) [gcc-8-branch revision 273027]
  • QMK Firmware version: 0.13.2
  • Any keyboard related software installed?
    • AutoHotKey
    • Karabiner
    • Other:

Additional Context

When Tab is held, it is treated as a Shift + Tab. My editor has a shortcut for Shift + Tab and Shift + Enter, but I had to program in a tap dance for Shift + Enter. Not the end of the world, but I think it's inconsistent.

Contributor guide

Research direction
Examine the Autoshift feature implementation in QMK firmware, specifically the handling of key hold events to understand why Shift+Enter is not generated when holding Enter with Autoshift enabled.
Tech stack
c
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CQMK firmware basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45