qmk/qmk_firmware

[Bug] X-bows Nature: red and blue LED colors interchanged

Open

#12,872 opened on May 11, 2021

View on GitHub
 (0 comments) (1 reaction) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Describe the Bug

This code should result in central (logo) LED being red:

void rgb_matrix_indicators_advanced_user(uint8_t led_min, uint8_t led_max) {
        RGB_MATRIX_INDICATOR_SET_COLOR(21, 255, 0, 0);
}

But in fact it becomes blue. And vise versa, it becomes red instead blue if change code as follows:

void rgb_matrix_indicators_advanced_user(uint8_t led_min, uint8_t led_max) {
        RGB_MATRIX_INDICATOR_SET_COLOR(21, 0, 0, 255);
}

Green is OK.

System Information

  • Keyboard: X-bows Nature
  • Operating system: Linux
  • AVR GCC version: 5.4.0
  • QMK Firmware version: master (77875e89eca07b2681ead5759d6e635823b24895)
  • Any keyboard related software installed?
    • AutoHotKey
    • Karabiner
    • Other:

Contributor guide

Research direction
Check the RGB matrix configuration for the X bows Nature keyboard, specifically the LED color order. Look for a BGR vs RGB swap in the keyboard's config.h or matrices.c file.
Tech stack
c
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CQMK
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65