qmk/qmk_firmware

[Bug] Toggling shift while holding a key assigned to an ANSI shifted keycode fails.

Open

#12,476 opened on Apr 3, 2021

View on GitHub
 (5 comments) (1 reaction) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Holding an ANSI shifted key and toggling shift produces output like the following:

!!!!!!!!!!!!!!1111111111
              ^shift released here

@JonasGessner noticed this here.

System Information

  • Keyboard: HHKB Pro JP Type-S with Hasu Controller
  • Operating system: NixOS, Windows 10, Arch Linux (QMK built on this system), Ubuntu
  • AVR GCC version: 10.2.0
  • ARM GCC version: 10.2.0
  • QMK Firmware version: 0.11.69
  • Any keyboard related software installed?
    • AutoHotKey
    • Karabiner
    • Other: Arch Linux system is a laptop using the X windowing system's ability to remap keys to a Dvorak layout - I forget how I did this, and am testing across multiple machines/OSs anyway.

Contributor guide

Research direction
Investigate the handling of ANSI shifted keycodes in QMK, specifically how the shift toggle interacts with keys held down. Trace the code path from key press to output, focusing on the shift register and keycode translation.
Tech stack
c
Domain
None
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CQMK firmware basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40