qmk/qmk_firmware

[Bug] Duck TC-V3 firmware - Indicator LEDs not functioning

Open

#11,754 opened on Feb 1, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Describe the Bug

After flashing the Duck TC-V3 PCB with the QMK firmware compiled and downloaded from QMK Configurator, the indicator LEDs (Caps, Scroll Lock, etc) no longer turn on/off. To verify the LED indicators operate correctly, when re-flashing to original firmware for O2D...the LED indicators work as expected.

Looking at the files in the QMK repository (keyboards/duck/tcv3), there are custom mapping and indicator_led.c/h files present. However, in the vtc3.c file has the code for backlighting and indicators has been commented out.

Would it be possible to have the firmware for the Duck TC-V3 updated to enable the functionality of the indicator LEDs?

Tagging @mechmerlin since you are listed as the keyboard maintainer

Contributor guide

Research direction
Inspect the commented out code in keyboards/duck/tcv3/tcv3.c and re enable indicator LED functionality by uncommenting the relevant sections. Ensure the indicator led.c/h files are properly included and compiled.
Tech stack
c
Domain
None
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitQMK basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70