qmk/qmk_firmware

[Bug] keycode from LT/MT still registers in Music

Open

#10,920 opened on Nov 11, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C (20,368 stars) (43,867 forks)batch import
bughelp wanted

Description

Describe the Bug

When activating the music mode, the mask is unable to stop the keycode from being output. Normally, it does this by returning false in process_music, but this doesn't stop the LT or MT keycodes from being emitted, as it happens in tmk_core/common/action.c rather than in quantum.

System Information

  • Keyboard: Moonlander, Planck EZ, but really any with audio
  • Operating system: Win, Mac
  • AVR GCC version: 8.x
  • ARM GCC version: 8.x
  • QMK Firmware version: latest

Contributor guide

Tech stack
c
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C programmingQMK firmware internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the processing of LT and MT keycodes in tmk core/common/action.c, specifically how they interact with the music mask. Look at the process music function in quantum/audio.c to understand how it returns false. The fix likely involves checking the music mask in the action execution path before emitting the keycode. See also the related issue #10920 comments (if any).
[Bug] keycode from LT/MT still registers in Music · qmk/qmk_firmware#10920 | Good First Issue