qmk/qmk_firmware

[Bug] Playing audio in music mode more than 11000 frequency render my keyboard useless

Open

#10,556 opened on Oct 5, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C (20,368 stars) (43,867 forks)batch import
bughelp wanted

Description

Describe the Bug

the music mode will make the keyboard laggy or useless when playing high frequency (more than 11000) in music mode. my fix is to map audio changing the last key to the low number so the last key not generating more than 11000 frequency.

const uint8_t music_map[MATRIX_ROWS][MATRIX_COLS] = KEYMAP(
       59, 60, 61, 62, 63, 64,     0,  1,  2,  3,  4,  5,  6,  7,
       45, 46, 47, 48, 49, 50,    51, 52, 53, 54, 55, 56, 57, 58,
       31, 32, 33, 34, 35, 36,    37, 38, 39, 40, 41, 42, 43, 44,
   16, 17, 18, 19, 20, 21, 22,    23, 24, 25, 26, 27, 28, 29, 30,
0,  1,  2,  3,  4,  5,  6,  7,     8,  9, 10, 11, 12, 13, 14, 15
);

there should be a way to limit the max frequency allowed in music mode. like the clicky mode.

System Information

  • ARM GCC version: 8.3.1
  • QMK Firmware version: 0.10.25
  • Any keyboard related software installed?
    • AutoHotKey
    • Karabiner
    • Other:

Additional Context

Contributor guide

Tech stack
c
Domain
backendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C programmingQMK firmware basicsmusic mode code
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the music mode implementation in QMK firmware, likely in `quantum/music.c`. Look for how frequencies are assigned to keys and if there is a limit similar to clicky mode in `clicky.c`. Consider adding a configurable max frequency constant or option. Test with a keyboard to ensure the fix resolves the lag without side effects.