qmk/qmk_firmware

[Bug] oled_write_pixel not painting vertical line SSD1306

Open

#10,074 opened on Aug 17, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Hi, I can't get a vertical line to be painted in the SSD1306(128x32) using the oled_write_pixel. In my keymap.c I have this code. This should paint a vertical line in the x = 16, from the start of the screen y =0 till the end y = 32. Here there is an image: Here

void oled_task_user(void)
{
    uint8_t x0 = 16;
    uint8_t x1 = 16;
    uint8_t y0 = 0;
    uint8_t y1 = 31;
    for (; x0 <= x1; x0++)
    {
        for (; y0 <= y1; y0++)
        {
            oled_write_pixel(x0, y0, true);
        }
    }
}

I don't have anything special in my rules.mk or anything... just the OLED_DRIVER_ENABLE = yes

Contributor guide

Research direction
Inspect the implementation of oled write pixel in the SSD1306 driver to understand how pixel addresses are computed. Check if there is a limitation that prevents drawing a vertical line due to page based addressing. Verify if the loop correctly increments coordinates.
Tech stack
c
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75