pywinauto/pywinauto

Add something like DoActionUntil() to make things stable

Open

#50 opened on Jul 2, 2015

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Python (4,425 stars) (654 forks)batch import
Priority-Lowenhancementhelp wanted

Description

Sometimes window messages and mouse/keyboard actions are not really handled by test application because of short non-responding state or another reason.

We need to introduce some stabilization feature for such cases. Unstable code:

taskbar.Clock.ClickInput()
ClockWindow = taskbar.explorer_app.Window_(class_name='ClockFlyoutWindow')
ClockWindow.Wait('visible') # WindowNotFound exception may be raised here from time to time

Stable modification proposal (ideally we should simply wrap unstable code with stabilizer):

ClockWindow = taskbar.explorer_app.Window_(class_name='ClockFlyoutWindow')
DoActionUntil(
    taskbar.Clock.ClickInput(),
    ClockWindow.Wait('visible')
)

Let's discuss how it can be done. ;)

Contributor guide

Tech stack
python
Domain
testing
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python programmingGUI automation conceptspywinauto basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Review the implementation of ClickInput and Wait in the pywinauto codebase (likely in `pywinauto/controls/` or `pywinauto/actions.py`). Check the 6 comments in the issue for proposed designs. Consider implementing a utility function that takes an action and a condition, retrying the action until the condition is met or a timeout occurs.