pytorch/text

[Help Want] Switch from common.torchtext_test_case.TorchtextTestCase to torch.testing._internal.common_utils.TestCase

Open

#824 opened on Jun 11, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (3,396 stars) (822 forks)batch import
help wanted

Description

TestCase.assertEqual supports torch.tensor. Here are a few files required to change:

  • test/*.py
  • test/data/test_*.py

Link example PRs: https://github.com/pytorch/text/pull/822 and https://github.com/pytorch/text/pull/823

Contributor guide

Tech stack
python
Domain
testing
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonPyTorch basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
This issue involves replacing all occurrences of 'common.torchtext test case.TorchtextTestCase' with 'torch.testing. internal.common utils.TestCase' in the test files. The change is straightforward and localized to test/*.py and test/data/test *.py. Refer to example PRs #822 and #823 for the exact pattern. No additional investigation is needed beyond renaming the class imports and usages.