pytorch/serve

permission error while trying to remove previous artifact files in `/tmp/`

Open

#1,532 opened on Mar 25, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (3,844 stars) (790 forks)batch import
good first issue

Description

https://github.com/pytorch/serve/blob/6a191f822f2e759c2aad07b8f9eacbedcb039827/model-archiver/model_archiver/model_packaging_utils.py#L137

In a multi-user system, this line can raise Permission Error because of the same file name in the shared /tmp/ directory which maybe created by another user. Maybe we can give more unique name when we store it using timestamp or something.

Contributor guide

Tech stack
pythonpytorch
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic PythonUnderstanding of file permissions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the permission error at model archiver/model packaging utils.py line 137. Consider using Python's tempfile module to create unique temporary files or append a timestamp/random string to the filename. Check if there are existing tests for this function and ensure the fix handles concurrent access gracefully.