pytorch/ignite

More EpochMetric's compute_fn output types

Open

#1,757 opened on Mar 8, 2021

View on GitHub
聽(3 comments)聽(0 reactions)聽(0 assignees)Python聽(4,313 stars)聽(602 forks)batch import
HacktoberfestPyDataGlobalenhancementhelp wantedmodule: metrics

Description

馃殌 Feature

Following https://github.com/pytorch/ignite/pull/1700#issuecomment-787151203 we would like to improve EpochMetric by supporting more output types returned by compute_fn:

  • EpochMetric should work with compute_fn outputs: scalars, tensors, tuple/list/mapping of tensors vs currently only scalars

A code snippet on possible implementation: https://github.com/pytorch/ignite/pull/1700#issuecomment-790413236 (It is not tested and maybe wrong, just an idea of how to do it).

It would be also helpful to raise a more user friendly error message if output type is not supported.

We need to update the docs as well.

If interested in fixing this issue, please leave a comment to assign the issue to you.

Contributor guide

Tech stack
pythonpytorch
Domain
machine learning
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with PyTorchUnderstanding of EpochMetric class
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the existing implementation of EpochMetric in the ignite codebase (likely in ignite/metrics/epoch metric.py). Understand how compute fn is currently used and the output types it supports. Examine the code snippet in the linked comment for a potential approach. Then implement support for scalars, tensors, and tuple/list/mapping of tensors. Also add a more user friendly error message for unsupported types. Finally, update the documentation to reflect the new capabilities.
More EpochMetric's compute_fn output types 路 pytorch/ignite#1757 | Good First Issue