pytorch/examples

MNIST test_loader not being used as intended (wrong)!

Open

#756 opened on Apr 19, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (21,634 stars) (9,429 forks)batch import
good first issue

Description

In the MNIST code, around line 57 (I think), the following code is wrong in my opinion for data, target in test_loader: It should be replaced by for idx,(data, target) in test_loader: The original code gives an error (int has no attribute .to(device)) as originally, data is actually assigned an integer (idx value) wrongly. I have verified this fix works. The code for training is correct but surprisingly there is a mistake in test code.

Contributor guide

Tech stack
python
Domain
machine learning
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonBasic PyTorch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is in the MNIST example code in the pytorch/examples repository, specifically in the test loop around line 57 of the mnist/main.py file. The bug is that `test loader` is iterated incorrectly: `for data, target in test loader` should be `for idx,(data, target) in test loader`. The fix is straightforward and confirmed by the issue author. To contribute, locate the file, apply the change, and submit a pull request.