pytorch/examples

The casting problem on the result of the model.

Open

#433 opened on Nov 1, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (9,429 forks)batch import
good first issue

Repository metrics

Stars
 (21,634 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In super_resolve.py, line 35, I think 'np.uint8(out_img_y[0])' should be 'np.uint8(out_img_y[0] + 0.5)'. This is because the value after the decimal point is discarded when casting. Would not rounding be better than discarding?

Contributor guide

Research direction
Examine the line in super resolve.py and confirm the casting behavior; consider adding 0.5 before casting to uint8 for proper rounding.
Tech stack
python
Domain
machine learning
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90