pytorch/examples

storing the best model

Open

#232 opened on Oct 12, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (9,429 forks)batch import
good first issue

Repository metrics

Stars
 (21,634 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://github.com/pytorch/examples/blob/7d0d413425e2ee64fcd0e0de1b11c5cca1f79f4d/word_language_model/main.py#L171 doesn't look like it is actually saving the best model? It saves only the current model

Contributor guide

Research direction
Examine the training loop in `main.py` to identify where the best model should be saved and compare with current saving logic.
Tech stack
pythonpytorch
Domain
machine learningai
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPythonPyTorch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75