unpack_sequence benchmark too fast on modern computers
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- python
- Domain
- performance, tooling
Research direction
Open pyperformance/data-files/benchmarks/bm_unpack_sequence/run_benchmark.py around line 457 and inspect the hardcoded inner_loops argument. Remove that argument so pyperf can choose the loop count, then verify the unpack_sequence benchmark timing and account for the required major version bump because prior results become invalid.
Written by the indexing model from the issue text.
Description
On modern computers, unpack_sequence completes in nanoseconds (!!!).
This is basically within the range of noise for modern computers. The cause is that for some reason, the inner loops are hardcoded instead of letting pyperf decide
The fix is simple: just remove the inner_loops argument. However, fixing this would need a major version bump, as all past unpack sequence results would be invalidated.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 203
- Avg merge
- 1h 20m
- Merged PRs (30d)
- 2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from python/pyperformance
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
python/pyperformance#346 · 3 comments ·
-
python/pyperformance#474 · 4 reactions · 1 assignee ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
python/pyperformance#473 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
python/pyperformance#464 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
python/pyperformance#460 · 2 comments · 1 reaction ·
All issues in python/pyperformance
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
learningequality/ricecooker#747 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
BSData/horus-heresy-3rd-edition#3171 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
run-llama/llama_index#23199 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
KhronosGroup/glTF-Blender-IO#2769 ·