Only Try a Unique Venv If There Is a Conflict
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- python
- Domain
- performance, tooling
Research direction
Trace the benchmark requirements-installation flow and review issue #158 for approaches to tracking installed versions. The change is complete when a unique virtual environment is used only for package-version conflicts, while other installation failures are reported without an automatic retry.
Written by the indexing model from the issue text.
Description
Currently any failure when installing a benchmark's requirements triggers the creation of a unique venv for that benchmark and a retry of the install. The only failure for which we need to create a unique venv is when there is a conflict with the version of already installed packages. Adjusting the code along those lines would speed things up when their are failures (e.g. wheel cannot build) and produce less noise.
Possible solutions:
- parse the text of the first install attempt to see if it a conflict
- this is fragile, as well as requiring that we "tee" the output of the "pip install" command
- instead of trying the common venv first, track the installed versions and use the common venv only if the benchmark's requirements are compatible
- #158 identifies several approaches to tracking installed versions
- this means we need to add some logic for checking requirements compatibility, though there is probably a good enough library out there (maybe in the stdlib)
Also see https://github.com/python/pyperformance/issues/144#issuecomment-1075822776.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 203
- Avg merge
- 1h 20m
- Merged PRs (30d)
- 2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from python/pyperformance
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
python/pyperformance#346 · 3 comments ·
-
python/pyperformance#474 · 4 reactions · 1 assignee ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
python/pyperformance#473 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
python/pyperformance#464 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
python/pyperformance#460 · 2 comments · 1 reaction ·
All issues in python/pyperformance
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
learningequality/ricecooker#747 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
BSData/horus-heresy-3rd-edition#3171 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
run-llama/llama_index#23199 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
KhronosGroup/glTF-Blender-IO#2769 ·