run --inherit-environ option does not work

Open
#139 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
cli, performance

Research direction

Start with the pyperformance run entry point and trace handling of --inherit-environ, using the reported bm_2to3/run_benchmark.py invocation as the reproduction path. Run the command from the issue and verify that the benchmark-running process receives HAHA=1 rather than an empty variable name.

Written by the indexing model from the issue text.

Description

After a clean install of pyperformance, run the below command:

HAHA=1 pyperformance run -f --debug-single-value --inherit-environ HAHA -b 2to3

The output received is:

[...]
[1/1] 2to3...
INFO:root:Running `$PATH_TO_VENV$/bin/python -u /usr/local/lib/python3.8/dist-packages/pyperformance-1.0.4-py3.8.egg/pyperformance/data-files/benchmarks/bm_2to3/run_benchmark.py --debug-single-value --inherit-environ =,PYPERFORMANCE_RUNID --output /tmp/tmpiq530yv4`

As you can see, the HAHA variable is not inherited by the benchmark-running process. Instead, a '=' symbol is parsed in its place.

Dominant language
Python
Stars
1k
Forks
203
Avg merge
1h 20m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python/pyperformance

All issues in python/pyperformance

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.