Consider reverting optimization in normalization

Open
#540 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Quiet
Tech stack
python
Domain
tooling

Research direction

Start by reading the discussion in issue #533 and inspecting commit 3e7f3ac6742a63ab729966c0ff8e205f92ac42f7. Run the repository's performance checks and compare the optimization's benefit with its complication; done means reaching and documenting a decision on whether it should be reverted.

Written by the indexing model from the issue text.

Description

In https://github.com/python/importlib_metadata/issues/533#issuecomment-4099281201_, I got the impression that the optimization may be premature. Now that code bases have stabilized and the performance checks are more precise, let's revisit 3e7f3ac6742a63ab729966c0ff8e205f92ac42f7 and decide if it's really worth the complication.

Dominant language
Python
Stars
142
Forks
97
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python/importlib_metadata

All issues in python/importlib_metadata

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.