Memory leak with _global_sinks

Open
#252 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python

Research direction

Start in core.py by tracing references to _global_sinks and checking why constructed sink objects are retained. Determine whether its purpose can be removed or whether a WeakSet preserves the needed behavior, then run the existing test suite to confirm sink construction and cleanup still work.

Written by the indexing model from the issue text.

Description

in core.py the set _global_sinks captures all constructed sink objects. What was it used for?
This should be either removed or replaced with a WeakSet

Dominant language
Python
Stars
1.3k
Forks
149
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python-streamz/streamz

All issues in python-streamz/streamz

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.