Incomplete license header for `src/libImaging/Arrow.h`
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 64/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- c
- Domain
- documentation
Research direction
Start with src/libImaging/Arrow.h and compare it with the referenced Apache Arrow cpp/src/arrow/c/abi.h and NOTICE.txt. Review the diff for omitted copyright, license, and modification details. Done means the bundled header and related attribution accurately reflect the third-party source and required Apache-2.0 notices.
Written by the indexing model from the issue text.
Description
What did you do?
Reviewed distributed/bundled files.
What did you expect to happen?
License headers of third-party code are applied correctly. Source most likely is https://github.com/apache/arrow/blob/main/cpp/src/arrow/c/abi.h
What actually happened?
Only a minimal header is included, as well as omitting the corresponding copyright data from the third-party licenses: https://github.com/python-pillow/Pillow/blob/9c1097c861420c77af53c7c9af2a1382e2bfaa8b/src/libImaging/Arrow.h#L4-L6 As the arrow project has a NOTICE.txt file, this further violates the terms of the Apache-2.0 license: https://github.com/apache/arrow/blob/main/NOTICE.txt
Additionally, executed changes have to be specified explicitly - doing a short diff of the file I found versus the file shipped by Pillow clearly show omissions and formatting changes.
Relevant sections from the license text: https://github.com/apache/arrow/blob/cb7383c71b7c87d45946eec1ba967472592e036b/LICENSE.txt#L98-L122
What are your OS, Python and Pillow versions?
- OS: irrelevant
- Python: irrelevant
- Pillow: main
- Dominant language
- Python
- Stars
- 13.8k
- Forks
- 2.5k
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 91
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from python-pillow/Pillow
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
python-pillow/Pillow#9997 · 2 comments ·
-
Documentation Font Rendering Third Party Framework
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
python-pillow/Pillow#9907 · 2 comments ·
-
Documentation
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
python-pillow/Pillow#9810 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
python-pillow/Pillow#9584 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
python-pillow/Pillow#10028 · 3 comments · 1 reaction ·
All issues in python-pillow/Pillow
Similar issues
-
documentation help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
simonw/sqlite-utils#872 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100