python-eel/Eel

Question about internal implementation

Open

#524 opened on Sep 24, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (570 forks)batch import
help wanted

Repository metrics

Stars
 (5,980 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi there! I have a question about the code here. Why is it necessary to find all the exposed JS functions before running? The Python side could send a message to the JS side asking to call a function with a specific name. Then, the JS side would check if such function exists, and if not, return an error. Thus, the current implementation seems overcomplicated to me.

Have you not considered this approach, or have you rejected it for some reason? Thanks.

Contributor guide

Research direction
Compare the current eager discovery of exposed JS functions with a lazy approach where the Python side sends a function call request and the JS side checks existence. Analyze trade offs in complexity, error handling, and performance. Look at the code starting at the linked line in init .py.
Tech stack
python
Domain
full stack
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonWeb development basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65