python-eel/Eel

close_callback -> how can I close any additional windows that are still open?

Open

#283 opened on Apr 21, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (570 forks)batch import
help wanted

Repository metrics

Stars
 (5,980 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello, First of all, thank you for eel and the support. the package helps me a lot!

I've created a 2 window app. the first one is launched by eel.start() and the second one is spawned from js code with window.open()

I'm trying to close the secondary window if the main one gets closed. So far I've managed to close the websocket by the close_callback function but no idea about how to close the browser itself...

Is there a built-in way to do it from eel or the websocket that I receive?

import eel

def eel_close_callback(closed_window_relative_path, list_of_opened_websockets):
    if closed_window_relative_path == main_window_path':
        for websocket in list_of_opened_websockets:
            websocket.close()


eel.start(config['db_handler_html_path'], size=size, close_callback=eel_close_callback)



<html>
   let map_window = window.open('map.html');
</html>

Desktop:

  • OS: linux
  • Browser chromium, chrome
  • Version 80

Contributor guide

Research direction
Explore the Eel source code to understand how windows are managed and how to close them programmatically.
Tech stack
pythonjavascript
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75