Evolve converts/validates again not changed fields
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
The only entry point named is attrs.evolve; start by tracing its implementation and the existing tests around evolve, then reproduce the frozen Settings example. Done means evolving only user does not reconvert or revalidate unchanged pwd, with regression coverage for that behavior.
Written by the indexing model from the issue text.
Description
Here's the usecase:
def decrypt_secret(value):
return ...
@attrs.frozen
class Settings:
user: str
pwd: str = attrs.field(converter=decrypt_secret)
sett = Settings(user="name", pwd=<encrypted_value>)
sett.pwd # already decrypted value
attrs.evolve(sett, user="name2")
This will fail, because it tries to decrypt already decrypted value, although the field pwd not changed at all.
Probably it is a wrong behaviour to convert/validate not changed fields.
Didn't find how to avoid converting/validating in this case.
- Dominant language
- Python
- Stars
- 5.8k
- Forks
- 480
- Avg merge
- 2h 15m
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from python-attrs/attrs
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
python-attrs/attrs#1620 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
python-attrs/attrs#1596 · 2 comments · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
python-attrs/attrs#1549 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
python-attrs/attrs#1543 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
python-attrs/attrs#1532 ·
All issues in python-attrs/attrs
Similar issues
-
documentation help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
simonw/sqlite-utils#872 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100