pytest-dev/pytest-testinfra

Support OS X

Open

#21 opened on Oct 14, 2015

View on GitHub
 (7 comments) (2 reactions) (0 assignees)Python (2,156 stars) (318 forks)batch import
enhancementhelp wanted

Description

Right now the test fail when running on OS X since SystemInfo.type == "darwin" is supported by the File module.

I resolved this in #20 by doing a check for SystemInfo.type.endswith("bsd") or SystemInfo.type == "darwin". Hopefully it would be that easy to get OS X working in the other modules.

Contributor guide

Tech stack
python
Domain
testinginfrastructure
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythonpytest testinfra basicsSystemInfo module
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine the fix in pull request #20 (likely merged) to see how OS X was supported in the File module. Identify other modules in the repository that use SystemInfo.type and apply similar conditions for 'darwin' or endswith('bsd') or equals 'darwin'. Check for any platform specific code that might need adjustment.